Skip to content

fix(contacts): create new contacts in the selected address book #5764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whoalin1 wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

fix(contacts): create new contacts in the selected address book #5764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/components/ContactDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,10 +1188,31 @@ export default defineComponent({
groupNames: this.newGroupsValue,
contact: this.contact,
})

// New contact + different address book: move locally before createVCard
// so Activity credits the final book (create-then-move logged the default).
// See https://github.com/nextcloud/contacts/issues/5757
const pendingAddressBookId = this.newAddressBook
const isNewContact = !this.contact.dav
if (
isNewContact
&& pendingAddressBookId
&& pendingAddressBookId !== this.contact.addressbook.id
) {
const addressbook = this.addressbooks.find((ab) => ab.id === pendingAddressBookId)
if (addressbook) {
this.updateAddressBookAccesses(pendingAddressBookId)
// createVCard uses localContact.addressbook — keep the clone in sync
this.localContact.addressbook = addressbook
await this.moveContactToAddressbook(pendingAddressBookId)
this.newAddressBook = null
}
}

await this.updateContact()
if (this.newAddressBook && this.newAddressBook !== this.contact.addressbook.id) {
this.updateAddressBookAccesses(this.newAddressBook)
this.moveContactToAddressbook(this.newAddressBook)
await this.moveContactToAddressbook(this.newAddressBook)
this.newAddressBook = null
}
this.editMode = false
Expand Down