Skip to content

fix(EntityPicker): prevent close button overlapping modal title - #5765

Open
whoalin1 wants to merge 1 commit into
nextcloud:mainfrom
whoalin1:fix/entity-picker-close-title-overlap
Open

whoalin1 wants to merge 1 commit into
nextcloud:mainfrom
whoalin1:fix/entity-picker-close-title-overlap

Conversation

@whoalin1

@whoalin1 whoalin1 commented Oct 6, 2026 •

Copy link
Copy Markdown

Summary

  • Prevents the NcModal close button from overlapping the EntityPicker title in the group “Add contacts” / “Add members to group” dialog.
  • Adds padding-inline-end on .entity-picker__title sized to the default clickable area plus a small gap so the title clears the close control.

Closes #3828

Testing

  1. Open Contacts.
  2. Create (or select) a contacts group.
  3. Open the group menu → Add contacts.
  4. Confirm the modal title no longer overlaps the close (X) button at rest or on hover.

AI disclosure

This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.

All commits carry an Assisted-by: Cursor:grok-4.7 trailer.

Assisted-by: Cursor:grok-4.7
Signed-off-by: whoalin1 <whoalin414@gmail.com>
@whoalin1
whoalin1 force-pushed the fix/entity-picker-close-title-overlap branch from 330070f to 5f484bd Compare October 9, 2026 14:13
@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group *Add contacts* has overlapping modal close button

1 participant