Conversation
1 of 2 tasks
kyteinsky
force-pushed
the
chore/guard-metadata-service
branch
2 times, most recently
from
August 13, 2026 14:13
07549bb to
f30f7d6
Compare
… outputs Signed-off-by: kyteinsky <kyteinsky@gmail.com>
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
chore/guard-metadata-service
branch
from
September 30, 2026 09:30
f30f7d6 to
8a79716
Compare
marcelklehr
requested changes
Sep 30, 2026
| continue; | ||
| } catch (InvalidArgumentException $e) { | ||
| $this->logger->warning('Could not extract item id from the source id', ['source_id' => $source['source_id'], 'exception' => $e]); | ||
| continue; |
Member
There was a problem hiding this comment.
Would perhaps be even better to simply catch \Throwable here, as loading the provider class can fail in unexpected ways (who knows what people do in their apps)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)