Skip to content

feat: refactor settings to new design - #7366

Merged
juliusknorr merged 1 commit into
mainfrom
reorganize-settings
Nov 19, 2025
Merged

juliusknorr merged 1 commit into
mainfrom
reorganize-settings

Conversation

@luka-nextcloud

@luka-nextcloud luka-nextcloud commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Summary

  • Use NcAppSettingsDialog for setting dialog
  • Use NcAppSettingsShortcutsSection, NcFormBox and NcFormBox* components
  • Show version number

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 12, 2025
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Nov 12, 2025
Comment thread src/components/DeckAppSettings.vue Outdated

@grnd-alt grnd-alt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments about the same variable.
I know it's the same variable usage as in AppNavigation before, but I do think we can just get rid of it, please double check that though.

Otherwise good🔥

Comment thread src/components/DeckAppSettings.vue Outdated
Comment thread src/components/DeckAppSettings.vue Outdated
Comment thread src/components/DeckAppSettings.vue
Comment thread src/components/DeckAppSettings.vue Outdated
Comment on lines +61 to +63
<p class="app-settings-section__version">
{{ t('deck', 'Deck version: {version}', { version: deckVersion }) }}
</p>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part doesn't need to be added manually — it will be rendered automatically in the next nextcloud-vue release (already implemented and merged).

Comment thread src/components/DeckAppSettings.vue Outdated
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr
juliusknorr merged commit 44d0496 into main Nov 19, 2025
34 checks passed
@juliusknorr
juliusknorr deleted the reorganize-settings branch November 19, 2025 10:57
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 19, 2025
@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Deck settings reorganization

4 participants