Skip to content

Submit changes to board color and name on enter key press - #7640

Merged
grnd-alt merged 1 commit into
nextcloud:mainfrom
theoholl:submit-board-name-or-color-change-on-enter-key-press-clean
Feb 16, 2026
Merged

grnd-alt merged 1 commit into
nextcloud:mainfrom
theoholl:submit-board-name-or-color-change-on-enter-key-press-clean

Conversation

@theoholl

@theoholl theoholl commented Feb 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The form for changing the board color and name has 2 buttons, one to cancel the changes and one to save them. Because both buttons are of native-type="submit" and the cancel button comes first, color and name changes are discarded when the input field is submitted via enter key.

Per the HTML spec, when you press Enter in a text field, the browser implicitly submits the form by firing a synthetic click event on the form's first submit button.

This PR changes the button type of the button with the cancel action to button instead of submit. Now, when the changes are submitted, e.g. via enter key press, the changes are getting saved correctly.

Screencast.Fix.mp4

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl theoholl changed the title Change button type for cancel action from submit to button Submit changes to board color and name on enter key press Feb 12, 2026
@grnd-alt

Copy link
Copy Markdown
Member

thanks for this small UI fix, your work is always much appreciated! @theoholl

@grnd-alt
grnd-alt merged commit 504469b into nextcloud:main Feb 16, 2026
36 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@luka-nextcloud

Copy link
Copy Markdown
Contributor

/backport to stable32

@backportbot

backportbot Bot commented Sep 3, 2026

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/7640/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b89a4e6c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7640/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@luka-nextcloud

Copy link
Copy Markdown
Contributor

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug when renaming and / or choosing another color for the board

3 participants