Repository navigation
Conversation
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
grnd-alt
left a comment
There was a problem hiding this comment.
This change is generally correct, thanks!
But I think showing cards from the active board in the lower section that is titled "Search for <> in other Boards" is a bit unexpected behavior. If it's from the active board it should also be shown in the top part imo.
As a side note: selecting 'show archived cards' in the top part will also show archived cards while searching, but currently you can only show either archived or not archived. So maybe we can adapt the filter in some way to have an option to show archived and unarchived and automatically set that when using the search bar.
Up for discussion though if my opinion is not shared here we could also merge as is.
Thank you for your feedback, in that case i would say lets close this PR as the functionality is as it's supposed to be (ill drop a message on the main issue ticket and explain) because for this it's as you said, it searched all other board and if they want to see full results (un/archived) then user can use global search. |
Summary
If user inside Board A search for keyword 'Card', if Board A has two cards of Card A and Card B (which is archived), will not be shown in search result.
TODO
Updated the login that inside Board A when search for keyword 'Card', the archived result (Card B) show to the user.
Checklist