Skip to content

fix: user may be null - #7705

Merged
miaulalala merged 1 commit into
mainfrom
fix/noid/user-may-not-be-found
Mar 4, 2026
Merged

miaulalala merged 1 commit into
mainfrom
fix/noid/user-may-not-be-found

Conversation

@miaulalala

Copy link
Copy Markdown
Contributor
  • Resolves: #
  • Target version: main

Summary

Found in my logs during tests:

"CustomMessage":"OC\\Group\\Manager::getUserGroupIds(): Argument #1 ($user) must be of type OCP\\IUser, null given, called in /var/www/html/apps-extra/deck/lib/Db/BoardMapper.php on line 108 in file '/var/www/html/lib/private/Group/Manager.php' line 352"

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84619 was 84323 (+0.35%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

grnd-alt
grnd-alt approved these changes Mar 4, 2026 •
Comment thread lib/Db/BoardMapper.php Outdated
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalala force-pushed the fix/noid/user-may-not-be-found branch from 8b8356d to fbfb88a Compare March 4, 2026 12:10
@miaulalala
miaulalala enabled auto-merge March 4, 2026 12:10
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84626 was 84323 (+0.35%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@miaulalala

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@miaulalala
miaulalala merged commit 7d5a420 into main Mar 4, 2026
42 of 43 checks passed
@miaulalala
miaulalala deleted the fix/noid/user-may-not-be-found branch March 4, 2026 12:15
@miaulalala

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@backportbot

backportbot Bot commented Mar 4, 2026

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/7705/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fbfb88a8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7705/stable32

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/7705/stable32."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants