Skip to content

feat: collaborative description editing - #8297

Open
grnd-alt wants to merge 9 commits into
mainfrom
feature/collaborative-description-editing
Open

feat: collaborative description editing#8297
grnd-alt wants to merge 9 commits into
mainfrom
feature/collaborative-description-editing

Conversation

@grnd-alt

@grnd-alt grnd-alt commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Target version: main

Summary

collaborative editing of the description.
requires: nextcloud/text#9062

TODO

  • text's last saved indicator says 57 years ago
  • old description saving mechanism still interfering
  • another user updated description notification pops up when notify_push is on
  • conflict view (needed/possible?)
  • attachments (requires text, see text pr) ⚠️ postponed
  • cypress failures

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 200687 was 198420 (+1.14%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 202839 was 198420 (+2.22%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 202734 was 198420 (+2.17%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 202750 was 198420 (+2.18%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt
feat: collaborative description editing
b1d9a7f 
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
feature(description): conflict dialog
dbbc851 
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
fix(description): render basic markdown editor correctly
1c4a2fc 
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
fix(description): show last saved date for description
e60962e 
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
fix(description): exclusively update description when saving from Text
6bbe8e7 
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
fix(psalm): stub Text app classes used by the context provider
4e9fbf3 
Assisted-by: ClaudeCode:claude-sonnet-5-5
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
fix(text): translate card lookup errors to Text context exceptions
94c68e6 
Assisted-by: ClaudeCode:claude-sonnet-5-5
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
grnd-alt force-pushed the feature/collaborative-description-editing branch from 80fd23d to 4e18194 Compare October 15, 2026 10:11
@grnd-alt
fix(text): register description listener only when Text is available
35626a5 
Assisted-by: ClaudeCode:claude-sonnet-5-5
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
grnd-alt force-pushed the feature/collaborative-description-editing branch from 4e18194 to 35626a5 Compare October 15, 2026 10:15
@grnd-alt
fix(cypress): wait for the text save request instead of the deck api …
5dd557f 
…save

Signed-off-by: grnd-alt <git@belakkaf.net>
@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 202828 was 198420 (+2.22%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 202924 was 198420 (+2.26%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt
grnd-alt marked this pull request as ready for review October 15, 2026 12:20
@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 202844 was 198420 (+2.22%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@samin-z
samin-z self-requested a review October 15, 2026 12:56
max-nextcloud
max-nextcloud reviewed Oct 15, 2026
View reviewed changes
Comment thread lib/Listeners/TextDocumentContentListener.php

@max-nextcloud max-nextcloud Oct 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little confused by the name. Sounds like it would listen to updates of the Document Content while actually it listens to updates of the card content. But maybe it fits your naming scheme.

max-nextcloud
max-nextcloud approved these changes Oct 15, 2026
View reviewed changes

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had a brief look at things I thought were critical. Sadly don't have more time to look into the details before vacation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes
@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner
@samin-z samin-z Awaiting requested review from samin-z

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grnd-alt @max-nextcloud