Skip to content

fix: remove trailing separators from CSV export - #8363

Open
Kumar-s75 wants to merge 2 commits into
nextcloud:mainfrom
Kumar-s75:fix/csv-export-trailing-separators
Open

Kumar-s75 wants to merge 2 commits into
nextcloud:mainfrom
Kumar-s75:fix/csv-export-trailing-separators

Conversation

@Kumar-s75

Copy link
Copy Markdown

Summary

  • format CSV list values with join(', ') instead of trimming a manually appended separator
  • remove trailing commas from tag and assigned-user fields
  • preserve CSV escaping for embedded double quotes
  • add tests for multiple values, quoted values, and empty lists

Verification

  • npx jest src/services/BoardApi.spec.js --runInBand --config='{"rootDir":".","moduleFileExtensions":["js"],"transform":{"^.+\\.js$":"babel-jest"}}'
  • npx eslint src/services/BoardApi.js src/services/BoardApi.spec.js
  • npm run build

All checks passed. The build reports existing Sass deprecation and bundle-size warnings.

Closes #8361

Signed-off-by: Kumar Saurabh <kumarsaurabh27d@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@grnd-alt grnd-alt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but please don't put the test file just in the services folder put it either in src/services/tests or in src/tests

@Kumar-s75

Copy link
Copy Markdown
Author

Thank you for the review, @grnd-alt. I have moved the test file to src/services/tests/BoardApi.spec.js and updated its import as requested.

The change has been pushed in commit f014d497e. All three focused Jest tests, ESLint, and whitespace checks pass.

The update is ready for another review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSV export leaves trailing commas in tags and assigned-user fields

2 participants