Conversation
Signed-off-by: Kumar Saurabh <kumarsaurabh27d@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
grnd-alt
left a comment
There was a problem hiding this comment.
looks good to me, but please don't put the test file just in the services folder put it either in src/services/tests or in src/tests
|
Thank you for the review, @grnd-alt. I have moved the test file to The change has been pushed in commit The update is ready for another review. |
Summary
join(', ')instead of trimming a manually appended separatorVerification
npx jest src/services/BoardApi.spec.js --runInBand --config='{"rootDir":".","moduleFileExtensions":["js"],"transform":{"^.+\\.js$":"babel-jest"}}'npx eslint src/services/BoardApi.js src/services/BoardApi.spec.jsnpm run buildAll checks passed. The build reports existing Sass deprecation and bundle-size warnings.
Closes #8361