Repository navigation
Conversation
021a9d7 to
c800c19
Compare
|
server implementation is not decided yet. setting it on draft for now |
Companion to nextcloud/server's new sync-enabled WebDAV property (https://github.com/Merpzz/server/tree/feature/sync-disabled-external-storage, addressing nextcloud/server#15701). Reads the new nc:sync-enabled property alongside the existing nc:is-encrypted one in both places the "choose what to sync" folder tree gets built: - FolderWizardRemotePath (initial account setup wizard) - FolderStatusModel (adding/managing sync folders on an already connected account — the actual real-world trigger case: a new external storage share appearing on an account that's already syncing) A mount with sync disabled server-side, and everything beneath it, is now excluded from the tree entirely, the same way encrypted subfolders already are — so it can never be accidentally selected for automatic sync, while remaining fully browsable/downloadable via web and mobile. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Merpzz <296625793+Merpzz@users.noreply.github.com>
c800c19 to
d2df90a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Companion to nextcloud/server#64325, which adds a new
nc:sync-enabledWebDAV property so an admin can mark an External Storage mount as excluded from client sync while it stays browsable via web/mobile (addresses nextcloud/server#15701).This teaches the client to actually respect that property.
What this changes
Reads the new
nc:sync-enabledproperty alongside the existingnc:is-encryptedone, in both places the "choose what to sync" folder tree gets built:FolderWizardRemotePath— initial account setup wizardFolderStatusModel— adding/managing sync folders on an already-connected account (the actual real-world trigger case: a new external storage share appearing on an account that's already syncing, which today can silently start pulling an arbitrarily large share to someone's disk with no warning)A mount with sync disabled server-side, and everything beneath it, is excluded from the tree entirely — same handling encrypted subfolders already get — so it can't be accidentally selected for automatic sync.
Testing
Manually verified end-to-end: built this branch as a Linux AppImage (via the official
continuous-integration-client-appimage-qt6CI image/build-appimage.shscript), connected it to a real running instance of the companion server PR, and confirmed toggling the server-side option off/on live correctly made the mount disappear/reappear from the folder picker, while a control mount with the option left enabled worked normally throughout.No existing automated test coverage exists for either
FolderWizardRemotePathorFolderStatusModelto extend (the one test file forFolderStatusModel,test/testfolderstatusmodel.cpp, is already markedQSKIPas known-broken independent of this change) — flagging for maintainer awareness rather than silently skipping it.Server-side companion
nextcloud/server#64325
🤖 Generated with Claude Code