fix: path segments and query params combined

[pReya]

closes #1058

• When visiting a subpath of an external site whose URL contains query parameters (e.g. ?jwt={jwt}), the path was naively concatenated onto the full URL string, producing malformed URLs like https://example.com/app?jwt=TOKEN/some/path
• The URL is now properly parsed with parse_url() so the path is inserted before the query string, producing https://example.com/app/some/path?jwt=TOKEN

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[provokateurin]

I'm not so happy about manually assembling the URL again, but I couldn't find a better solution either.

The URL could contain user and pass, so you need to take care of that as well: https://www.php.net/manual/en/function.parse-url.php#refsect1-function.parse-url-returnvalues

[pReya]

I'm not so happy about manually assembling the URL again, but I couldn't find a better solution either.

The URL could contain user and pass, so you need to take care of that as well: https://www.php.net/manual/en/function.parse-url.php#refsect1-function.parse-url-returnvalues

Thanks for the review. I agree about this feeling not very elegant, but I'm afraid this is the only way to handle this. I've added user and pass parts now, too.

[provokateurin]

Thanks!

[provokateurin]

/backport to stable33

[provokateurin]

/backport to stable32

[provokateurin]

You need to fix psalm. I think in this case it makes sense to throw a RuntimeException if scheme or host are not present, because it should never actually happen in reality.

[provokateurin]

Thanks!

[provokateurin]

/backport to stable33

[provokateurin]

/backport to stable32

[backportbot]

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/1059/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4ec7d141

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1059/stable33

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1059/stable33."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[backportbot]

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/1059/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4ec7d141

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1059/stable32

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1059/stable32."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.