Conversation
The hidden file input was triggered via native label forwarding through an NcButton wrapped in <label for="uploadicon">. NcButton attaches its own click handler and renders a <button> inside the <label> (invalid interactive content), so the click never reached the input and no file picker opened. Replace the label with an explicit @click handler that programmatically clicks the hidden input via a template ref. Fixes nextcloud#1113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1113
Problem
On Administration → External sites, clicking "Upload new icon" did nothing: no file picker opened, no network request fired, no console error.
Root cause
The hidden
<input type="file">was triggered via native label forwarding through anNcButtonwrapped in<label for="uploadicon">.NcButtonattaches its own click listener and swallows the event before native label → input forwarding happens (a<button>inside a<label>is also invalid interactive content, so browsers won't do label activation anyway).Fix
Drop the
<label>wrapper and give theNcButtonan explicit@clickhandler that programmatically clicks the hidden input through a Vue template ref. Triggering the input directly was already proven to work in the issue thread, and the upload backend path is unchanged.Testing
Built from this branch and deployed the resulting
js/external-admin.mjs(+ matching CSS) onto a Nextcloud 34 / External 9.0.1 instance: the file picker now opens, the upload completes with "Icon uploaded successfully", and the icon appears in the list. Page styling verified intact.🤖 AI (if applicable)
(but verified by a human)