Skip to content

fix(icon): skip pixel dimension check for SVG uploads #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mchugh19 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(icon): skip pixel dimension check for SVG uploads #1160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Controller/IconController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ public function uploadIcon(): DataResponse {
], Http::STATUS_UNPROCESSABLE_ENTITY);
}

if ($imageSize !== false && (!in_array($imageSize[0], [16, 24, 32], true) || $imageSize[0] !== $imageSize[1])) {
// Not a square
if ($icon['type'] !== 'image/svg+xml' && $imageSize !== false && (!in_array($imageSize[0], [16, 24, 32], true) || $imageSize[0] !== $imageSize[1])) {
// Not a square - SVG is vector-based and scales to any size, so skip the pixel dimension check
return new DataResponse([
'error' => $this->l10n->t('Provided image is not a square of 16, 24 or 32 pixels width'),
], Http::STATUS_UNPROCESSABLE_ENTITY);
Expand Down