Conversation
This was referenced Sep 3, 2026
artonge
force-pushed
the
feature/moveTeamFolder_into_adminsettings
branch
from
September 3, 2026 17:52
c34c298 to
e8a5a57
Compare
1 task done
Contributor
|
I extracted the implementation of the missing |
Member
There was a problem hiding this comment.
Since some parts of this PR were extracted from here and added on #5078 (already merged), please rebase this PR to sync with master.
tomek2k1
force-pushed
the
feature/moveTeamFolder_into_adminsettings
branch
from
September 4, 2026 12:51
e8a5a57 to
afe8065
Compare
tomek2k1
force-pushed
the
feature/moveTeamFolder_into_adminsettings
branch
from
September 8, 2026 12:30
09987ad to
ed18f47
Compare
cristianscheid
left a comment
cristianscheid
left a comment
Member
There was a problem hiding this comment.
beside comments below, there are also some conflicts to be resolved
|
|
||
| $query = $this->selectWithFileCache(); | ||
| $query->leftJoin('f', 'group_folders_groups', 'g', $query->expr()->eq('f.folder_id', 'g.folder_id')) | ||
| ->where($query->expr()->orX( |
Member
There was a problem hiding this comment.
Doesn't this allow returning duplicate folder rows? For example, if a folder has more than one row in group_folders_groups (e.g. shared with multiple groups).
Maybe we could do something similar to what's done on getAllFoldersWithSize() and add a groupBy('f.folder_id')?
…der table Co-authored-by: Copilot <copilot@github.com> GPT-5.6 Terra Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>
tomek2k1
force-pushed
the
feature/moveTeamFolder_into_adminsettings
branch
2 times, most recently
from
September 10, 2026 10:14
fa0d637 to
be9b876
Compare
…ota support in admin Settings Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>
Co-authored-by: Cristian Scheid <74515775+cristianscheid@users.noreply.github.com> Signed-off-by: Tomasz Trillò <t.trillo@gmx.de>
tomek2k1
force-pushed
the
feature/moveTeamFolder_into_adminsettings
branch
from
September 10, 2026 10:16
be9b876 to
cc9334d
Compare
Contributor
Author
|
Unnecessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the Team Spaces integration by allowing an existing group folder to be linked as a team's primary team folder.
🤖 AI (if applicable)