Conversation
Signed-off-by: Tomasz Trillò <tomasz.trillo@dataport.de>
Signed-off-by: Tomasz Trillò <tomasz.trillo@dataport.de>
tomek2k1
force-pushed
the
fix/team-groupfolders-separation
branch
from
September 21, 2026 12:37
f22a707 to
9e65acd
Compare
tomek2k1
marked this pull request as ready for review
September 21, 2026 12:37
tomek2k1
enabled auto-merge
September 21, 2026 12:37
artonge
reviewed
Sep 30, 2026
| */ | ||
| private function applyFolderTypeFilter(IQueryBuilder $query, string $folderType): void { | ||
| if ($folderType === 'group') { | ||
| $query->andWhere($query->expr()->isNull('f.team_circle_id')); |
Contributor
There was a problem hiding this comment.
Can we remove that column and instead have a column to specify which application is managing this groupfolder?
This would allow us to do the following:
$query->andWhere($query->expr()->eq('f.managed_by', 'groupfolders'));
tomek2k1
disabled auto-merge
September 30, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates Teams settings from Groupfolder settings in administration.
Fixes #5112
Before:
After:
🤖 AI (if applicable)