Skip to content

fix: show clear error message when Giphy API requests fail - #74

Merged
oleksandr-nc merged 1 commit into
mainfrom
fix/rate-limit-warning
Mar 2, 2026
Merged

oleksandr-nc merged 1 commit into
mainfrom
fix/rate-limit-warning

Conversation

@oleksandr-nc

@oleksandr-nc oleksandr-nc commented Feb 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #37

Changes proposed in this PR:

  • Forward actual HTTP status codes from the Giphy API instead of always returning 400
  • Display specific error message for rate limits (429): Too many requests to Giphy. Please contact your administrator.
  • Display generic error message for other API failures: Failed to load GIFs
  • Use AlertIcon for error states to visually distinguish from "No results"

How to easy test this

  1. Go to Admin settings → Connected accounts → Giphy integration
  2. Set any invalid API key (e.g. abc123) and save
  3. Open the GIF picker (e.g. via the smart picker in Text or Talk)
  4. Before this PR: you see the sad GIF with "No results" — no indication of what went wrong
  5. After this PR: you see an alert icon with "Failed to load GIFs"

Tests from my setup

Invalid API key (unknown error)

Before this PR:

Screenshot From 2026-02-28 14-11-35

After this PR:

Screenshot From 2026-02-28 14-07-25

This was emulated, I have changed backend to return always 429 error:

Screenshot From 2026-02-28 14-10-40

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
@oleksandr-nc
oleksandr-nc marked this pull request as ready for review February 28, 2026 12:13

@julien-nc julien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Comment thread src/views/GifCustomPickerElement.vue
@oleksandr-nc
oleksandr-nc merged commit 4e35633 into main Mar 2, 2026
13 checks passed
@oleksandr-nc
oleksandr-nc deleted the fix/rate-limit-warning branch March 2, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No clear warning when gifs don't load

2 participants