Repository navigation
fix: keep the settings page working when the API key cannot be decrypted - #90
Merged
Merged
Conversation
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
michelleDeko
added a commit
to michelleDeko/integration_klipy
that referenced
this pull request
Aug 16, 2026
Syncs the fork with nextcloud/integration_giphy up to 2.2.2 (14 commits). Upstream changes taken: - Nextcloud 35 support, IConfig resolved via container->get() instead of query() - Keep the admin settings page working when the stored API key cannot be decrypted (nextcloud#90), plus the accompanying AdminTest unit test - nextcloud/coding-standard 1.5 + cs:fix (import blank lines, migration header) - CI: node-build.yml replaced by node.yml, new psalm.yml, action bumps (checkout v7.0.1, setup-node v7.0.0, pr-feedback-action) - Build tooling: node/npm engines, quoted stylelint patterns, dropped stylelint rules removed upstream, corrected SPDX license id (APL -> AGPL) - Translation updates for el, et_EE, fr, lt_LT, sv, tr Fork adaptations applied on top: - Kept the Klipy branding: namespace OCA\Klipy, app id integration_klipy, Klipy wording in the new decrypt-failure log message and AdminTest - Translation updates remapped from the Giphy source strings to the Klipy ones; upstream keys with no Klipy equivalent (rating filter levels, the Giphy developer-settings sentence) were dropped - node.yml runs on ubuntu-latest instead of the Nextcloud-internal ubuntu-latest-low runner label, which does not resolve in this fork - Kept the fork's conditional signing/publishing in appstore-build-publish.yml - Version 3.0.1 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admin::getForm()decrypted the storedapi_keywith no guard. If the stored value is not valid ciphertext - set as plaintext viaocc, or encrypted under a secret that has since changed -decrypt()throws out ofgetForm().Now caught and logged as a warning, with the key treated as unset - the admin simply sees an empty API key field and can re-enter it
🤖 AI (if applicable)