Repository navigation
Refactor provider registration and implement multiple services - #431
Conversation
… at the same time Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
lukasdotcom
left a comment
There was a problem hiding this comment.
Looks nice I've tried it out and it works well on my dev instance. A few things that caught my attention while trying it out though:
-
Quota rules seem to apply to all services, but there is still a usage quota for each individual service. Probably worth it to keep that consistent and allow for specifying a service for quota rules too.
-
Model list here seems to need to be reloaded every single time to see all the models (That might be on purpose though).
julien-nc
left a comment
There was a problem hiding this comment.
Amazing, I love it. It works very well, is way more flexible than before and is very nicely done!
A few remarks.
- When adding the first service, it is expanded. But when adding a service when there are services already, the new service is not expanded. I think this is the intended behaviour. Not a big deal, just in case you want to consistently expand freshly added services.
- When an integration_openai provider was selected for a task type before upgrading, there is no provider set after upgrading (at least when i did it in my dev env). Not sure if you wanted a transparent migration. It seems possible since the previously selected default model is automatically added as an exposed one. So there is a new candidate provider to replace the old one in the taskprocessing settings.
- About "detect modalities", I think we need more guidance. We could at least tell the user they have to refresh and select some models after the modalities have been detected.
- It is a bit confusing that the model lists go away after a page refresh. I understand why it's done like that and I'm not sure this should change. But we could make it easier to understand for users. Maybe changing the button label to "Get model list" is better since it implies we don't have it yet.
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
5eb895c to
f438f02
Compare
…rovider IDs Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
Refresh is now implicit upon page load / service expansion in the UI. Shall we just select a default model for the user in the same step? |
|
@copilot resolve the merge conflicts in this pull request |
…r-model # Conflicts: # lib/TaskProcessing/EmojiProvider.php # lib/TaskProcessing/HeadlineProvider.php Co-authored-by: marcelklehr <986878+marcelklehr@users.noreply.github.com>
Resolved by merging |


fixes #148
fixes #229
🤖 AI (if applicable)