Skip to content

fix: use max tokens parameter everywhere - #435

Merged
lukasdotcom merged 1 commit into
mainfrom
max-tokens
Sep 14, 2026
Merged

lukasdotcom merged 1 commit into
mainfrom
max-tokens

Conversation

@lukasdotcom

Copy link
Copy Markdown
Member

For thinking models limiting the max tokens does not work as thinking tokens are counted breaking these providers.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>

@edward-ly edward-ly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@lukasdotcom
lukasdotcom merged commit 89814b8 into main Sep 14, 2026
25 checks passed
@lukasdotcom
lukasdotcom deleted the max-tokens branch September 14, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants