Conversation
This reverts commit f9dfdf8.
…n/default Signed-off-by: Arkadiusz Sitkiewicz <a.sitkiewicz@wbgroup.com>
…dmin/default Signed-off-by: Arkadiusz Sitkiewicz <a.sitkiewicz@wbgroup.com>
…er/admin Signed-off-by: Arkadiusz Sitkiewicz <a.sitkiewicz@wbgroup.com>
…pt - admin Signed-off-by: Arkadiusz Sitkiewicz <a.sitkiewicz@wbgroup.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable system prompts for summary and translation tasks
Earlier work:
php occ, was rejected because oftalk_meetingflag. The idea was to usetext2textprovider for Talk. I made a PR tospreedand it was merged feat(talk): support configurable call summary prompts spreed#19111Related work:
There is already merged functionality for configurable system prompts set by admin #433 (@Abhijeet-035, @lukasdotcom) introduces that, so I think that I should explain myself and my work a little, considering
SummaryProviderI started working on this PR before #433 was merged, so those two PRs overlap. I implemented the prompt per service using
ServiceConfigwhich is why instance-wide setting from #433 is reverted. I reverted it to keep one place in UI instead of two. I am happy to keep global default as fallback if you prefer.Summary system prompts
There are 3 types of system prompts configuration:
user system prompt(Advanced options in Assistant UI)admin system prompt(that can be set in Admin Settings > Assistant)default system prompt(hard-coded in repo:You are a helpful assistant that summarizes text in the same language as the text. You should only return the summary without any additional information.How it works:
user system prompt(if set) overridesadmin system prompt(if set) anddefault system prompt. It also ignoresformatandcomplexityoptions. The idea is that user knows what they want and the can define thiers output format however they wantsadmin system prompt(if set) overwritesdefault system promptand can be overwritten byuser system prompt(if set). It appendsformatandcomplexityoption, so the idea is that prompt should be more general and should not defineformatandcomplexitydefault system promptwill be used only ifuser system promptandadmin system promptare not setTranslation system prompt
I introduce that because I had troubles with translation. Sometimes model outputs only translated text and sometimes it outputs orginal text + translation line by line. It was not coherent
UI look
Admin system prompts for summarization and translation
System promptsText generationso if we toggle that off,System prompts will not be visibleUser defined system prompt for summary