Skip to content

[stable12] fix: Upgrade node version #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 4 commits into from
Aug 26, 2026
+13 −5
Merged

[stable12] fix: Upgrade node version #1562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b48f8c5
fix: Upgrade node version
marcelklehr Aug 25, 2026
f34b77f
fix(ci): Fix psalm issues
marcelklehr Aug 25, 2026
372662a
fix(nodejs): Downgrade to node v22
marcelklehr Aug 25, 2026
513eca8
fix(ci): Test against stable34
marcelklehr Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/full-run-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
movinet-enabled: ['true']
include:
# test pure-js once
- server-versions: master
- server-versions: stable34
databases: sqlite
php-versions: 8.2
pure-js-mode: true
Expand Down
2 changes: 1 addition & 1 deletion lib/BackgroundJobs/ClusterFacesJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ protected function run($argument): void {
$userId = (string)$argument['userId'];
try {
$iniValue = ini_get('memory_limit');
if ($iniValue === false) {
if ($iniValue === false || $iniValue === '') {
$batchSize = 10_000;
} else {
$memoryBytes = ini_parse_quantity($iniValue);
Expand Down
2 changes: 1 addition & 1 deletion lib/Migration/InstallDeps.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
use Psr\Log\LoggerInterface;

final class InstallDeps implements IRepairStep {
public const NODE_VERSION = 'v20.9.0';
public const NODE_VERSION = 'v22.23.2';
public const NODE_SERVER_OFFICIAL = 'https://nodejs.org/dist/';
public const NODE_SERVER_UNOFFICIAL = 'https://unofficial-builds.nodejs.org/download/release/';

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
"vue": "^2.7.14"
},
"engines": {
"node": "20.x",
"npm": "10.x"
"node": "22.x",
"npm": "11.x"
},
"browserslist": [
"extends @nextcloud/browserslist-config"
Expand Down
8 changes: 8 additions & 0 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
<code><![CDATA[$jobClass === static::class]]></code>
</TypeDoesNotContainType>
</file>
<file src="lib/BackgroundJobs/ClusterFacesJob.php">
<RedundantCastGivenDocblockType>
<code><![CDATA[(string)$argument['userId']]]></code>
</RedundantCastGivenDocblockType>
</file>
<file src="lib/Classifiers/Classifier.php">
<MixedAssignment>
<code><![CDATA[$results]]></code>
Expand Down Expand Up @@ -960,6 +965,9 @@
</PossiblyFalseArgument>
</file>
<file src="lib/Service/FsActionService.php">
<RedundantCastGivenDocblockType>
<code><![CDATA[(string)$userId]]></code>
</RedundantCastGivenDocblockType>
<UndefinedClass>
<code><![CDATA[$e]]></code>
<code><![CDATA[NoUserException]]></code>
Expand Down
Loading