Skip to content

fix(setup): hide config section if autoconfig is valid #56231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Oct 1, 2026
Merged

fix(setup): hide config section if autoconfig is valid #56231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/views/WebInstaller.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ describe('Default setup page', () => {
await expect(component.findByRole('textbox', { name: 'Administration account name' })).resolves.not.toThrow()
await expect(component.findByLabelText('Administration account password')).resolves.not.toThrow()
await expect(component.findByRole('textbox', { name: 'Data folder' })).resolves.not.toThrow()

// Database and storage section is expanded without autoconfig
const advancedConfig = component.getByText('Storage & database').closest('details')!
expect(advancedConfig.open).toBe(true)
expect(advancedConfig.style.display).toBe('')
})

it('Renders single DB sqlite', async () => {
Expand Down Expand Up @@ -368,7 +373,7 @@ describe('Setup page with autoconfig', () => {

// Database and storage section is hidden as already set in autoconfig
await expect(component.findByText('Storage & database')).resolves.not.toThrow()
expect(component.getByText('Storage & database').closest('details')!.getAttribute('hidden')).toBeNull()
expect(component.getByText('Storage & database').closest('details')!.style.display).toBe('none')
})
})

Expand Down
2 changes: 1 addition & 1 deletion core/src/views/WebInstaller.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
</fieldset>

<!-- Autoconfig toggle -->
<details :open="!isValidAutoconfig" data-cy-setup-form-advanced-config>
<details v-show="!isValidAutoconfig" open data-cy-setup-form-advanced-config>
<summary>{{ t('core', 'Storage & database') }}</summary>

<!-- Data folder -->
Expand Down
Loading