fix(dav): allow ExternalCalendar as schedule-default-calendar-URL - #61602
stephan1827 wants to merge 1 commit into
Conversation
When a user tries to set an ExternalCalendar (e.g. from integration_davc) as the default calendar for scheduling, CustomPropertiesBackend::validateProperty() rejects it with 'No such calendar' because it only accepts instances of OCA\DAV\CalDAV\Calendar, not OCA\DAV\CalDAV\Integration\ExternalCalendar. ExternalCalendar is already imported in the file but was unused in the instanceof check. Extend the validation to also accept ExternalCalendar nodes, running a simplified check (VEVENT support only) since these calendars are always writable and cannot be subscriptions, shared, or deleted. Signed-off-by: stephan1827 <stephan@stricker.cloud>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Your PR description is AI-written, so I'm closing it as per our AI policy: https://github.com/nextcloud/.github/blob/master/AI_POLICY.md#human-written-communication |
|
Why would you reject just because it was AI written? There is clear description and a small code change that takes like 2 minutes to review. |
|
It doesn't matter how small or important the change is, you didn't follow our AI policy. |
|
ok, I changed it |
|
Thanks! |
|
The change seems fine in general, but it would probably be better to adjust |
This branch has not been deployed
4 participants
Summary
You can not set external calendars as default calendar. The attached code fixes that.