fix(sharing): Hide Allow download and sync option for federated - #62470
Merged
Merged
Conversation
enjeck
requested review from
kristian-zendato,
sorbaugh and
susnux
and removed request for
a team
July 24, 2026 01:12
Collaborator
|
Makes sense for backports to 33 and 34, but I think it conflicts with the ongoing work on unify sharing on 35. |
Collaborator
|
/backport! to stable34 |
Collaborator
|
/backport! to stable33 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
enjeck
force-pushed
the
fix/hide-download-federated
branch
from
September 3, 2026 08:11
5848a0c to
bad590f
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
fix/hide-download-federated
branch
from
September 4, 2026 02:59
bad590f to
94b98a0
Compare
Contributor
Author
|
/backport! to stable34 |
Contributor
Author
|
/backport! to stable33 |
Contributor
Author
|
/backport! to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/62470/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 94b98a03
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62470/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
susnux
approved these changes
Sep 16, 2026
Contributor
|
/backport to stable35 |
artonge
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide the “Allow download and sync” option for federated user/group shares because the setting is not enforced end to end for remote recipients.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)