Skip to content

fix: make top nav bar right elements within a nav #63239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Sep 22, 2026
Merged

fix: make top nav bar right elements within a nav #63239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,21 @@
flex: 1 0;
}
}

// List wrapper for notifications / contacts / account (and injected entries)
&__items {
display: inline-flex;
align-items: center;
justify-content: flex-end;
list-style: none;
margin: 0;
padding: 0;
}

&__item {
display: flex;
align-items: center;
}
}

// Public layout related headers
Expand Down
6 changes: 4 additions & 2 deletions core/css/mobile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,17 @@
}

@media only screen and (max-width: 480px) {
#header .header-end > div > .menu {
#header .header-end > div > .menu,
#header .header-end__item > div > .menu {
max-width: calc(100vw - 10px);
position: fixed;
&::after {
display: none !important;
}
}
/* Arrow directly child of menutoggle */
#header .header-end > div {
#header .header-end > div,
#header .header-end__item > div {
&.openedMenu {
&::after {
display: block;
Expand Down
1 change: 0 additions & 1 deletion core/src/views/AccountMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<NcHeaderMenu
id="user-menu"
class="account-menu"
is-nav
:aria-label="t('core', 'Settings menu')"
:description="avatarDescription">
<template #trigger>
Expand Down
18 changes: 13 additions & 5 deletions core/templates/layout.user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,19 @@
<div class="header-center">
<div id="unified-search"></div>
</div>
<div class="header-end">
<div id="notifications"></div>
<div id="contactsmenu"></div>
<div id="user-menu"></div>
</div>
<nav class="header-end" aria-label="<?php p($l->t('Notifications, contacts and settings')); ?>">

@susnux susnux Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimishavijay or @kra-mo do you have a better idea how to label the section of the navigation here? (the part including notifications, assistent, contacts etc)

@nimishavijay nimishavijay Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are all rather distinct apps there, and if anyone using a screenreader heard something generic for this category like "More apps" or something like that, they may skip over it entirely.

If there is any way we can take them out of this section and have them be directly accessible that would be the best from a UX persepctive. If that's not possible then I'd suggest "Nextcloud Assistant, notifications and settings" to indicate the most commonly used apps.

In the future we could also think about moving the assistant to the center section as it's closer in function to searching, then the top right group could become "Notifications and settings" which makes more sense in my head.
@kra-mo any thoughts here since you worked on the new layout?

@kra-mo kra-mo Sep 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original proposal did have Assistant next to search, but I wonder about the balance if we have suggested apps on the left in the future.

As for the label, considering it also includes the people menu for example, I really am not sure what to call it. I do think something generic may be the best, but without using the word "app". For regular users, I would reserve that word for apps in the grid. Maybe "Actions and options"?

<ul class="header-end__items">
<li class="header-end__item">
<div id="notifications"></div>
</li>
<li class="header-end__item">
<div id="contactsmenu"></div>
</li>
<li class="header-end__item">
<div id="user-menu"></div>
</li>
</ul>
</nav>
</header>

<div id="content" class="app-<?php p($_['appid']) ?>">
Expand Down
Loading