Repository navigation
Conversation
Assisted-by: OpenCode:gpt-5.6-sol Signed-off-by: redsteadz <harcolemas@gmail.com>
0567f26 to
ed82de3
Compare
| } | ||
|
|
||
| // Only works outside of the main files view | ||
| if (view.id === 'files') { |
There was a problem hiding this comment.
when is this needed? Meaning when is this action ever useful in the files view?
As the files view is already the action target view this would end up in?
There was a problem hiding this comment.
When doing search this action never appears, even though the file is within some xyz folder, and instead of just the file. I want to go to the actual folder. So instead of just disabling by view.id files, we can check if we are in the same folder as actual file, then no need to show this.
| <div class="filesSidebarSubname__path"> | ||
| {{ node.path }} |
There was a problem hiding this comment.
when the filepath is visible from the current path (e.g. files view or folder tree) then this is quite confusing to people. IMHO this should be move to its own section to make it a bit cleaner.
There was a problem hiding this comment.
Okk, fair point, will update with a different section and a label
joshtrichards
added
enhancement
good first issue
| inline | ||
| :path="mdiStar" | ||
| :name="t('files', 'Favorite')" /> | ||
| <div :class="$style.filesSidebarSubname__path"> |
There was a problem hiding this comment.
I meant this one - the path should only be shown if its not in the current folder.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This branch has not been deployed
4 participants
Summary
TODO:
Before:
After:
Checklist
3. to review, feature component)stable32)AI (if applicable)
The tests written were made using the help of GPT-5.6 Sol