Skip to content

Hide "Shared by link" when sharing by link is disabled - #63400

Merged
susnux merged 3 commits into
masterfrom
fix/share-by-link
Sep 25, 2026
Merged

Hide "Shared by link" when sharing by link is disabled#63400
susnux merged 3 commits into
masterfrom
fix/share-by-link

Conversation

@susnux

@susnux susnux commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Copy of PR to be able to adjust it for making CI green.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI
    • Playwright tests generated with AI

@susnux susnux added this to the Nextcloud 35 milestone Aug 18, 2026
@susnux
susnux requested a review from a team as a code owner August 18, 2026 19:50
@susnux susnux added the bug label Aug 18, 2026
@susnux
susnux requested review from kristian-zendato, skjnldsv and sorbaugh and removed request for a team August 18, 2026 19:50
@susnux susnux added 3. to review Waiting for reviews feature: sharing labels Aug 18, 2026
@susnux
susnux force-pushed the fix/share-by-link branch from e06f3ba to e155d3a Compare August 18, 2026 19:54
@susnux susnux mentioned this pull request Aug 18, 2026
Merged
7 tasks
@susnux

susnux commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@susnux

susnux commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@susnux
susnux force-pushed the fix/share-by-link branch from e155d3a to d4f9354 Compare August 18, 2026 20:08
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 20, 2026
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 25, 2026
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 27, 2026
Merged
@susnux

susnux commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

/compile rebase

pboguslawski and others added 3 commits September 25, 2026 15:52
@pboguslawski @nextcloud-command
fix(sharing): hide "Shared by link" when sharing by link is disabled
a577197 
Related: #50323
Author-Change-Id: IB#1156670
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
@susnux @nextcloud-command
fix: adjust code to comply with ESLint and align code with tests
018ad68 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command
chore(assets): Recompile assets
4998ef1 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit 90a6b67 into master Sep 25, 2026
132 of 134 checks passed
@susnux
susnux deleted the fix/share-by-link branch September 25, 2026 15:57
@susnux

susnux commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@backportbot backportbot Bot mentioned this pull request Sep 25, 2026
Closed
3 tasks
This was referenced Sep 25, 2026
Open
Open
@backportbot backportbot Bot mentioned this pull request Sep 25, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@kristian-zendato kristian-zendato Awaiting requested review from kristian-zendato kristian-zendato is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

[Bug]: "Shared by link" displayed when sharing by link is disabled

5 participants

@susnux @skjnldsv @AndyScherzinger @pboguslawski @nextcloud-command