fix(AppMenuItem): Don't bold active label - #63549
Merged
Merged
Conversation
kra-mo
added
bug
design
kra-mo
requested review from
kristian-zendato,
pringelmann,
skjnldsv and
sorbaugh
and removed request for
a team
August 25, 2026 07:38
pringelmann
approved these changes
Aug 25, 2026
AndyScherzinger
force-pushed
the
fix/don't-bold-app-labels
branch
from
September 4, 2026 19:55
cda8dd7 to
599d7ac
Compare
AndyScherzinger
approved these changes
Sep 4, 2026
susnux
reviewed
Sep 16, 2026
Since this can shift the layout around in ugly ways Signed-off-by: kramo <git@kramo.page>
kra-mo
force-pushed
the
fix/don't-bold-app-labels
branch
from
September 21, 2026 09:01
599d7ac to
4810725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Don't bold the label of the active item in the app menu, since this can shift the layout around in ugly ways. For example, before:
After:
And the selected app is indicated in the top bar and tab title anyway.
Checklist
3. to review, feature component)stable32)I wasn't able to actually test the code for unrelated reasons, but I hope this is correct.
cc @pringelmann