Skip to content

feat(dav): allow muting reminders per calendar - #63774

Merged
SebastianKrupinski merged 1 commit into
nextcloud:masterfrom
SoleroTG:feat/per-calendar-ignore-reminders
Sep 10, 2026
Merged

SebastianKrupinski merged 1 commit into
nextcloud:masterfrom
SoleroTG:feat/per-calendar-ignore-reminders

Conversation

@SoleroTG

@SoleroTG SoleroTG commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds the CalDAV property {http://nextcloud.com/ns}ignore-reminders to calendars and dav_shares database tables to allow users to mute background event notifications (email and push) on a per-calendar basis.

  • Migration Version1038Date20260828000000 adding ignore_reminders boolean columns to calendars and dav_shares.
  • WebDAV PROPPATCH/PROPFIND handling in CalDavBackend.php.
  • Per-recipient filtering in ReminderService.php ensuring independent muting for owners and sharees.
  • Unit tests added in CalDavBackendTest.php.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests are included
  • Screenshots before/after for front-end changes
  • Documentation has been updated or is not required

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SebastianKrupinski

SebastianKrupinski commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Hi @SoleroTG

Thank you for the PR. But please put back the original PR description and modify the information

Also can you rebase your changes on the latest master please

@SebastianKrupinski SebastianKrupinski self-assigned this Aug 28, 2026
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Aug 28, 2026
@SoleroTG
SoleroTG force-pushed the feat/per-calendar-ignore-reminders branch from 4a06cd0 to ddcfe7b Compare August 28, 2026 14:56
@joshtrichards joshtrichards added enhancement feature: caldav Related to CalDAV internals labels Aug 28, 2026
@SoleroTG
SoleroTG force-pushed the feat/per-calendar-ignore-reminders branch from ddcfe7b to cc0d81e Compare August 30, 2026 09:24
@SoleroTG
SoleroTG force-pushed the feat/per-calendar-ignore-reminders branch from cc0d81e to dd56257 Compare August 31, 2026 13:54
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/per-calendar-ignore-reminders branch 2 times, most recently from cfb52d4 to f52c588 Compare September 1, 2026 23:30
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Hi @SoleroTG

I fixed this PR for you, as it was just easier then explaining it, in multiple back and forth conversations. Your AI agent implemented this completely wrong.

I did make some comments in the calendar PR, which you can fix.

@SebastianKrupinski
SebastianKrupinski force-pushed the feat/per-calendar-ignore-reminders branch from f52c588 to c14785b Compare September 1, 2026 23:38
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/per-calendar-ignore-reminders branch from c14785b to d1a8338 Compare September 1, 2026 23:39
@SoleroTG

SoleroTG commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Hi @SebastianKrupinski, thanks for fixing this.

I adjusted my nextcloud pipeline to pay more attention next time.

@SebastianKrupinski
SebastianKrupinski force-pushed the feat/per-calendar-ignore-reminders branch from d1a8338 to f7dd7e7 Compare September 2, 2026 12:39
Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski force-pushed the feat/per-calendar-ignore-reminders branch from f7dd7e7 to abe8d0e Compare September 5, 2026 15:15
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

@ChristophWurst @DerDreschner @odzhychko @hamza221

Can I get a second on this please

@SebastianKrupinski
SebastianKrupinski merged commit e42897a into nextcloud:master Sep 10, 2026
153 checks passed
@welcome

welcome Bot commented Sep 10, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement feature: caldav Related to CalDAV internals feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable or enable notifications on a per calendar basis

4 participants