Skip to content

fix(tags): broken tag deletion on user delete - #63972

Merged
pulsejet merged 2 commits into
masterfrom
pulsejet/tagdel-fix
Sep 6, 2026
Merged

fix(tags): broken tag deletion on user delete#63972
pulsejet merged 2 commits into
masterfrom
pulsejet/tagdel-fix

Conversation

@pulsejet

@pulsejet pulsejet commented Sep 2, 2026

Copy link
Copy Markdown
Member

There's a typo here. It's getting tagIds but then trying to use it as a uid. This causes hard failures.

@pulsejet
pulsejet requested a review from a team as a code owner September 2, 2026 21:32
@pulsejet pulsejet added the ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient. label Sep 2, 2026
@pulsejet
pulsejet requested review from Altahrim, leftybournes, provokateurin and sorbaugh and removed request for a team September 2, 2026 21:32
@provokateurin

provokateurin commented Sep 3, 2026

Copy link
Copy Markdown
Member

/backport to stable35

@provokateurin

provokateurin commented Sep 3, 2026

Copy link
Copy Markdown
Member

/backport to stable34

@provokateurin

provokateurin commented Sep 3, 2026

Copy link
Copy Markdown
Member

/backport to stable33

@provokateurin provokateurin added this to the Nextcloud 36 milestone Sep 3, 2026
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Sep 3, 2026
@pulsejet @AndyScherzinger
fix(tags): broken tag deletion on user delete
89c6473 
There's a typo here. It's getting tagIds but then trying to use it as a
uid. This causes hard failures.

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@pulsejet
pulsejet enabled auto-merge September 6, 2026 17:31
@pulsejet
pulsejet merged commit ff2090e into master Sep 6, 2026
153 checks passed
@pulsejet
pulsejet deleted the pulsejet/tagdel-fix branch September 6, 2026 18:00
This was referenced Sep 6, 2026
Merged
Merged
Merged
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@provokateurin provokateurin provokateurin approved these changes
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feedback-requested ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient.

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

3 participants

@pulsejet @provokateurin @susnux