Skip to content

fix(files): do not display hidden files count on public shares - #64085

Open
fauzanfebrian wants to merge 1 commit into
nextcloud:masterfrom
fauzanfebrian:fix/39027-public-share-hidden-files-count
Open

fauzanfebrian wants to merge 1 commit into
nextcloud:masterfrom
fauzanfebrian:fix/39027-public-share-hidden-files-count

Conversation

@fauzanfebrian

@fauzanfebrian fauzanfebrian commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This pull request removes the display of the hidden files count in the summary on public share pages.

While dot files are already hidden in the public grid/list view, the footer summary was still displaying "X hidden". Since public users do not have access to toggle the visibility of hidden files via a gear icon, showing this helper text is unnecessary and leaks metadata about the presence of hidden files.

This change modifies getSummaryFor in fileUtils.ts to accept a hideHiddenString argument, and leverages the existing isPublic prop in FilesList.vue to skip appending the hidden files string when rendering a public share.

Screenshots (Before / After)

Public Share Link (The Fix)

Before After
before-public-link after-public-link

Internal Logged-in View (Regression Check)

Before After
before after

TODO

  • Pass isPublic flag to getSummaryFor
  • Unit test getSummaryFor with new arguments

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Disclosure: This pull request was assisted by Antigravity (Gemini 3.1 Pro).

@fauzanfebrian
fauzanfebrian requested review from a team and skjnldsv as code owners September 6, 2026 13:12
@fauzanfebrian
fauzanfebrian requested review from kristian-zendato and sorbaugh and removed request for a team September 6, 2026 13:12
@fauzanfebrian
fauzanfebrian force-pushed the fix/39027-public-share-hidden-files-count branch from da237a4 to 4d16404 Compare September 6, 2026 13:18
Hidden files visibility can be configured internally, but on public shares this information is irrelevant and leaks the presence of hidden files. This passes the isPublic flag to getSummaryFor to skip generating the hidden files summary.

Fixes nextcloud#39027

Assisted-by: Antigravity:Gemini-3.1-Pro
Signed-off-by: Fauzan Febriansyah <fauzanfebriann@gmail.com>
@fauzanfebrian
fauzanfebrian force-pushed the fix/39027-public-share-hidden-files-count branch from 4d16404 to e6fe4df Compare September 6, 2026 13:50
@solracsf solracsf added this to the Nextcloud 36 milestone Sep 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to hide "hidden files" on public shares

2 participants