Repository navigation
fix(files): do not display hidden files count on public shares - #64085
fauzanfebrian wants to merge 1 commit into
Conversation
da237a4 to
4d16404
Compare
Hidden files visibility can be configured internally, but on public shares this information is irrelevant and leaks the presence of hidden files. This passes the isPublic flag to getSummaryFor to skip generating the hidden files summary. Fixes nextcloud#39027 Assisted-by: Antigravity:Gemini-3.1-Pro Signed-off-by: Fauzan Febriansyah <fauzanfebriann@gmail.com>
4d16404 to
e6fe4df
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This pull request removes the display of the hidden files count in the summary on public share pages.
While dot files are already hidden in the public grid/list view, the footer summary was still displaying "X hidden". Since public users do not have access to toggle the visibility of hidden files via a gear icon, showing this helper text is unnecessary and leaks metadata about the presence of hidden files.
This change modifies
getSummaryForinfileUtils.tsto accept ahideHiddenStringargument, and leverages the existingisPublicprop inFilesList.vueto skip appending the hidden files string when rendering a public share.Screenshots (Before / After)
Public Share Link (The Fix)
Internal Logged-in View (Regression Check)
TODO
isPublicflag togetSummaryForgetSummaryForwith new argumentsChecklist
3. to review, feature component)stable32)AI (if applicable)