[stable32] Allow quota write streams with unknown free space - #64340
Merged
Merged
Conversation
backportbot
Bot
requested review from
Altahrim,
icewind1991,
leftybournes,
salmart-dev and
susnux
and removed request for
a team
September 15, 2026 09:08
backportbot
Bot
added
bug
3. to review
Assisted-by: Codex:GPT-5 Signed-off-by: veryCrunchy <me@verycrunchy.dev>
chrip
force-pushed
the
backport/61706/stable32
branch
from
September 16, 2026 10:17
3fe2f99 to
33dd6c0
Compare
4 tasks
icewind1991
approved these changes
Sep 23, 2026
chrip
self-requested a review
September 23, 2026 14:13
chrip
approved these changes
Sep 23, 2026
chrip
left a comment
chrip
left a comment
Contributor
There was a problem hiding this comment.
Approving — clean backport of #61706, identical to the already-merged stable34 (#64342) and
stable35 (#64341) backports.
Two notes for whoever merges:
- The red CI is unrelated. The azure jobs fail at container init with
Docker pull failed with exit code 1, and the same cypress runners fail on the stable33 PR #64432, so both are
branch-wide flakes rather than anything from this one-line change. Needs a re-run, not a fix.
One correction to #61706's description, since it could get this backport closed as unnecessary:
it claims stable32 doesn't contain the affected Quota::writeStream() override. It does — the
$size < $free comparison is there, which is why this cherry-pick applies cleanly.
Assisted-by: ClaudeCode:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #61706