Skip to content

fix(Command): catch InvalidArgumentException if login-name option doesn't exist - #64364

Closed
edward-ly wants to merge 1 commit into
masterfrom
fix/noid/user-auth-tokens-login-name
Closed

edward-ly wants to merge 1 commit into
masterfrom
fix/noid/user-auth-tokens-login-name

Conversation

@edward-ly

Copy link
Copy Markdown
Contributor

Summary

In NC 33 and 34, the occ user:auth-tokens:add command fails due to the backports of #63555 (#63696, #63697). That fix introduces the login-name option which was first added in #59680 (NC 35) but not backported. This fix catches the exception that is thrown in case login-name is not defined.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…oesn't exist

Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly edward-ly added this to the Nextcloud 35.0.1 milestone Sep 15, 2026
@edward-ly
edward-ly requested a review from a team as a code owner September 15, 2026 16:05
@edward-ly
edward-ly requested review from icewind1991 and removed request for a team September 15, 2026 16:05
@edward-ly edward-ly added the bug label Sep 15, 2026
@edward-ly edward-ly added the 3. to review Waiting for reviews label Sep 15, 2026
@edward-ly

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@edward-ly

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@edward-ly

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@marcelklehr

Copy link
Copy Markdown
Member

I think this is already fixed: #63988

@edward-ly

Copy link
Copy Markdown
Contributor Author

I think this is already fixed: #63988

Ah, I had no idea, although it didn't contain links to the previous PRs so it wasn't easily findable. Anyway, hopefully the stable33/34 CI checks can be resolved soon if they haven't already.

@edward-ly edward-ly closed this Sep 16, 2026
@edward-ly
edward-ly deleted the fix/noid/user-auth-tokens-login-name branch September 16, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants