Repository navigation
fix(theming): read image keys from Mime-suffixed key in theming:config - #64381
shawon9324 wants to merge 20 commits into
Conversation
…ng:config occ theming:config <key> always reported image keys (background, logo, logoheader, favicon) as "currently not set", even when a value was configured and served correctly by the web UI. Image values are stored under "<key>Mime" in the theming app config, a convention already used by this command's list-all branch and by the value-writing branch further down. The single-key read branch was the only one still reading the plain key, so it never found the stored value. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Md. Shahriar Karim Shawon <shawon9324@gmail.com>
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Fixes occ theming:config <imageKey> so single-key reads use the MIME-suffixed config key (e.g., logoMime) consistently with the image write path and the list-all branch.
Changes:
- Update
UpdateConfigto read image keys from<key>Mimeinstead of<key>. - Add PHPUnit coverage for regular key reads and image key MIME-suffixed reads.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/theming/lib/Command/UpdateConfig.php | Fixes the config lookup for image keys by using the MIME-suffixed storage key. |
| apps/theming/tests/Command/UpdateConfigTest.php | Adds unit tests validating the corrected lookup behavior for regular and image keys. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Running
occ theming:config logoreported that the logo was not set, eventhough
theming.logoMimewas correctly set toimage/png. The single-keyimage read path was the only branch using the wrong storage key; the list-all
image branch and the image write path already correctly appended the
Mimesuffix. This change updates that lookup to use the correct image MIME
configuration key.
Verified on a local instance with
theming.logoMimeset toimage/png:Checklist
AI (if applicable)