fix(files): lazily load fileinfo in Node::getParentId, getMetadata and getData - #64408
Merged
Merged
Conversation
…d getData These methods used `$this->fileInfo` directly, unlike the other getters which go through `getFileInfo()`. Since the DAV root is now a LazyUserFolder whose real UserFolder is created without fileinfo, `FilesPlugin::handleGetProperties` triggered "Call to a member function getMetadata() on null" mid-stream for PROPFIND on the user root, producing invalid multistatus XML. Assisted-by: ClaudeCode:claude-fable-5-1 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
requested review from
Altahrim and
leftybournes
and removed request for
a team
September 16, 2026 06:57
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
CarlSchwan
approved these changes
Sep 16, 2026
susnux
approved these changes
Sep 16, 2026
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression fix after #53048.
These methods used
$this->fileInfodirectly, unlike the other getters which go throughgetFileInfo(). Since the DAV root is now a LazyUserFolder whose real UserFolder is created without fileinfo,FilesPlugin::handleGetPropertiestriggered "Call to a member function getMetadata() on null" mid-stream for PROPFIND on the user root, producing invalid multistatus XML.Assisted-by: ClaudeCode:claude-fable-5-1
Checklist
3. to review, feature component)stable32)AI (if applicable)