Skip to content

fix: Merge driverOptions correctly - #64445

Merged
susnux merged 1 commit into
nextcloud:masterfrom
eehakkin:fix/merge-driver-options-correctly
Sep 18, 2026
Merged

fix: Merge driverOptions correctly#64445
susnux merged 1 commit into
nextcloud:masterfrom
eehakkin:fix/merge-driver-options-correctly

Conversation

@eehakkin

@eehakkin eehakkin commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
  • keep numeric keys
  • handle missing defaults

Summary

Checklist

@eehakkin
eehakkin requested a review from a team as a code owner September 16, 2026 22:09
@eehakkin
eehakkin requested review from CarlSchwan, come-nc, icewind1991 and leftybournes and removed request for a team September 16, 2026 22:09
@eehakkin
eehakkin force-pushed the fix/merge-driver-options-correctly branch 3 times, most recently from e874cd0 to c5b0870 Compare September 16, 2026 22:24
@SystemKeeper
SystemKeeper requested a review from susnux September 17, 2026 04:27
@SystemKeeper

SystemKeeper commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@eehakkin
fix: Merge driverOptions correctly
f6b7a3d 
- keep numeric keys
- handle missing defaults

Signed-off-by: Eero Häkkinen <Eero+git@xn--Hkkinen-5wa.fi>
@eehakkin
eehakkin force-pushed the fix/merge-driver-options-correctly branch from c5b0870 to f6b7a3d Compare September 17, 2026 11:55
@icewind1991

icewind1991 commented Sep 17, 2026

Copy link
Copy Markdown
Member

rector failure is unrelated

@susnux
susnux merged commit 413f60d into nextcloud:master Sep 18, 2026
141 of 146 checks passed
@welcome

welcome Bot commented Sep 18, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@susnux

susnux commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

@backportbot backportbot Bot mentioned this pull request Sep 18, 2026
Merged
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@eehakkin
eehakkin deleted the fix/merge-driver-options-correctly branch October 1, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes
@susnux susnux susnux approved these changes
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Nextcloud 35.0.0 loses numeric dbdriveroptions keys

4 participants

@eehakkin @SystemKeeper @icewind1991 @susnux