Repository navigation
fix(files_external): add priority setter in DBConfigService - #64457
Draft
joshtrichards wants to merge 3 commits into
Draft
joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
joshtrichards
added this pull request to stack #64458
September 17, 2026 03:40
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/fix-StorageService-priorityUpdates
branch
from
September 17, 2026 03:41
b3f3149 to
4059ea3
Compare
StoragesService::updateStorage()` accepted updated priority values but never persisted them. As a result, changing a mount's priority appeared to succeed but was lost when the mount was reloaded. This is currently primarily a concern for the HTTP API: the web UI does not expose priority, while `files_external:import` creates new mounts and its parser does not currently import priority values (imported mounts receive the default priority). Persist priority changes passed to `updateStorage()` so updated precedence is retained for overlapping external storage mounts. Signed-off-by: Josh <josh.t.richards@gmail.com>
Make the global storage update endpoint use `100` as the default priority, matching the effective default in `StorageConfig`. When priority is omitted or `null`, the existing storage configuration flow already results in an effective priority of `100`, so this does not change runtime behavior. It makes the endpoint contract explicit and ensures omitted priorities are represented consistently before updated priorities are compared and persisted. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
2. developing
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StoragesService::updateStorage()accepted updated priority values but never persisted them. As a result, changing a mount's priority appeared to succeed but was lost when the mount was reloaded.This is currently primarily a concern for the HTTP API: the web UI does not expose priority, while
files_external:importcreates new mounts and its parser does not currently import priority values (imported mounts receive the default priority).Persist priority changes passed to
updateStorage()so updated precedence is retained for overlapping external storage mounts.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)