Repository navigation
fix: make file requests dialog accessible - #64471
kristian-zendato wants to merge 5 commits into
Conversation
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
|
|
||
| <div v-if="password !== null" class="file-request-dialog__password-field"> | ||
| <NcPasswordField | ||
| id="file-request-dialog-password" |
9e1b8f7 to
7d45d25
Compare
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
…equest UI Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
7d45d25 to
36d410a
Compare
|
|
||
| methods: { | ||
| returnFocusTarget(): HTMLElement | null { | ||
| return document.querySelector<HTMLElement>('[data-cy-upload-picker] button') |
There was a problem hiding this comment.
Ideally not use the data selected, but there is also no public "api" here. Maybe
| return document.querySelector<HTMLElement>('[data-cy-upload-picker] button') | |
| return document.querySelector<HTMLElement>('.upload-picker button') |
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
36d410a to
59ac106
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Improve a11y of the Create file request dialog:
<ul>/<li>with an accessible name (Recipient emails).Remove email: {email}instead of a sharedRemove email.<label for>, fields have stable ids, helper text isaria-describedby, and the expiration date keeps a visible linked label.Checklist
3. to review, feature component)stable32)AI (if applicable)