Skip to content

ci(psalm): Fail taint analysis action when it had errors #64622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 2 commits into from
Sep 28, 2026
+19 −8
Merged

ci(psalm): Fail taint analysis action when it had errors #64622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eaca1d
ci(psalm): Fail taint analysis action when it had errors
nickvergessen Sep 21, 2026
669bd90
fix: Psalm taint complaints
nickvergessen Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/static-code-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,14 @@ jobs:
run: composer i

- name: Psalm taint analysis
run: composer run psalm:security -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif
run: composer run psalm:security -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif --report-show-info=false

# Psalm exits 0 on taint findings when a report file is generated
- name: Fail on taint analysis findings
run: |
count=$(jq '[.runs[].results[]] | length' results.sarif)
echo "Taint analysis findings: $count"
test "$count" -eq 0

- name: Show potential changes in Psalm baseline
if: always()
Expand Down
14 changes: 9 additions & 5 deletions apps/workflowengine/lib/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,8 @@ public function deleteOperation(int $id, ScopeContext $scopeContext): bool {
* @param array $events
*/
protected function validateEvents(string $entity, array $events, IOperation $operation): void {
/** @psalm-suppress TaintedCallable newInstance is not called */
/** @psalm-taint-escape callable */
$entity = $entity;
$reflection = new \ReflectionClass($entity);
if ($entity !== IEntity::class && !in_array(IEntity::class, $reflection->getInterfaceNames(), true)) {
throw new \UnexpectedValueException($this->l->t('Entity %s is invalid', [$entity]));
Expand Down Expand Up @@ -653,7 +654,8 @@ public function validateOperation(string $class, string $name, array $checks, st
throw new \UnexpectedValueException($this->l->t('The provided operation data is too long'));
}

/** @psalm-suppress TaintedCallable newInstance is not called */
/** @psalm-taint-escape callable */
$class = $class;
$reflection = new \ReflectionClass($class);
if ($class !== IOperation::class && !in_array(IOperation::class, $reflection->getInterfaceNames(), true)) {
throw new \UnexpectedValueException($this->l->t('Operation %s is invalid', [$class]) . join(', ', $reflection->getInterfaceNames()));
Expand Down Expand Up @@ -687,14 +689,16 @@ public function validateOperation(string $class, string $name, array $checks, st
throw new \UnexpectedValueException($this->l->t('The provided check value is too long'));
}

$reflection = new \ReflectionClass($check['class']);
if ($check['class'] !== ICheck::class && !in_array(ICheck::class, $reflection->getInterfaceNames(), true)) {
/** @psalm-taint-escape callable */
$checkClass = $check['class'];
$reflection = new \ReflectionClass($checkClass);
if ($checkClass !== ICheck::class && !in_array(ICheck::class, $reflection->getInterfaceNames(), true)) {
throw new \UnexpectedValueException($this->l->t('Check %s is invalid', [$class]));
}

try {
/** @var ICheck $instance */
$instance = $this->container->get($check['class']);
$instance = $this->container->get($checkClass);
} catch (ContainerExceptionInterface) {
throw new \UnexpectedValueException($this->l->t('Check %s does not exist', [$class]));
}
Expand Down
4 changes: 2 additions & 2 deletions lib/private/Mail/Mailer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public function send(IMessage $message): array {
try {
$mailer->send($message->getSymfonyEmail());
} catch (TransportExceptionInterface $e) {
$logMessage = sprintf('Sending mail to "%s" with subject "%s" failed', print_r($message->getTo(), true), $message->getSubject());
$logMessage = sprintf('Sending mail to "%s" with subject "%s" failed', json_encode($message->getTo()), $message->getSubject());
$this->logger->error($logMessage, ['app' => 'core', 'exception' => $e]);
if ($debugMode) {
$this->logger->debug($e->getDebug(), ['app' => 'core']);
Expand All @@ -232,7 +232,7 @@ public function send(IMessage $message): array {
}

// Debugging logging
$logMessage = sprintf('Sent mail to "%s" with subject "%s"', print_r($message->getTo(), true), $message->getSubject());
$logMessage = sprintf('Sent mail to "%s" with subject "%s"', json_encode($message->getTo()), $message->getSubject());
$this->logger->debug($logMessage, ['app' => 'core']);

return [];
Expand Down
Loading