fix(files): chunk mounted storage IDs during scans - #64691
Open
joshtrichards wants to merge 2 commits into
Open
joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
The sharded filecache fallback can bind more than 1,000 mounted storage IDs in a single IN query. Limit each query to IQueryBuilder::MAX_IN_PARAMETERS IDs and continue through subsequent chunks until a user is found. Signed-off-by: Josh <josh.t.richards@gmail.com>
Cover early success in the initial query and mounted-storage fallback behavior for empty, multi-chunk, and unmatched storage lists. Assisted-by: Copilot:gpt-6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
September 23, 2026 14:21
joshtrichards
added
feature: filesystem
feature: database
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sharded filecache fallback could bind more than 1,000 mounted storage IDs in a single
INquery. Limit each query toIQueryBuilder::MAX_IN_PARAMETERSIDs and continue through subsequent chunks until a user is found. Also adds previously missing test coverage.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)