Skip to content

fix(SchemaChecker): don't block on unexpected-table finding - #64700

Draft
Antreesy wants to merge 3 commits into
fix/6405/schema-check-p3from
fix/64440/schema-check-p4
Draft

Antreesy wants to merge 3 commits into
fix/6405/schema-check-p3from
fix/64440/schema-check-p4

Conversation

@Antreesy

@Antreesy Antreesy commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • 'occ app:remove --keep-data' only deletes an app's code, leaving tables and appconfig (installed_version) in place
  • Those tables reported as blocking findings, instead of more similar "disabled app" list
  • An unexpected table that cannot be attributed to any known app or core is always informational in verbose output
  • example:
    • unexpected table 'oc_mail_tags'

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Antreesy Antreesy added this to the Nextcloud 36 milestone Sep 23, 2026
@Antreesy Antreesy self-assigned this Sep 23, 2026
@Antreesy Antreesy added bug 3. to review Waiting for reviews labels Sep 23, 2026
…ings

- 'occ app:remove --keep-data' only deletes an app's code, leaving tables and appconfig (installed_version) in place
- Those tables reported as blocking findings, instead of more similar "disabled app" list
- An unexpected table that cannot be attributed to any known app or core is always informational in verbose output
- example:
  - unexpected table 'oc_mail_tags'

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- 'occ app:remove --keep-data' only deletes an app's code, leaving tables and appconfig (installed_version) in place
- SchemaChecker::getFindings() without guard throws AppPathNotFoundException

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/6405/schema-check-p3 branch from 07dd851 to 7f5ce95 Compare September 23, 2026 22:00
- `occ upgrade` ran the schema check unconditionally after Updater::upgrade(), even when it returned false
- Findings against database in partially-upgraded state should not be considered a reliable marker

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/64440/schema-check-p4 branch from a426a85 to 1dcab0f Compare September 23, 2026 22:02
@Antreesy
Antreesy force-pushed the fix/6405/schema-check-p3 branch from 7f5ce95 to 208449f Compare September 23, 2026 22:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant