fix(settings): prevent user list crash when password changes are disabled - #64701
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
Tyagiquamar
requested review from
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
September 23, 2026 17:51
joshtrichards
added
3. to review
9 tasks
joshtrichards
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When password change is disabled because the master key is disabled, the UserList settings component attempted to call the legacy \window.OC.Notification.showTemporary\ API, which is undefined in modern Nextcloud web frontends and crashed the users management page before user rows could render.
This replaces the legacy call with \showWarning\ from @nextcloud/dialogs, matching Nextcloud's modern dialog and notification conventions.
Resolves #64685.