Conversation
szaimen
force-pushed
the
feat/theming-svg-favicon
branch
from
September 23, 2026 20:18
1e31afa to
21e740f
Compare
szaimen
added
2. developing
szaimen
force-pushed
the
feat/theming-svg-favicon
branch
from
September 24, 2026 09:20
21e740f to
8281c20
Compare
The favicon endpoint now returns an SVG that embeds the app icon on the themed background, instead of rendering an ICO file with imagick. This removes the imagick requirement for favicons and allows uploading SVG favicons without imagick. Touch icons need to be PNG for Safari "Add to Dock" and the iOS home screen, so they are still rendered with imagick when available and fall back to the default touch icon otherwise. An uploaded favicon is served as-is by both endpoints. The manifest declares the type of the served icons, and the social media preview image of shares is only replaced by the touch icon if it is a raster image. The imagick setup check now only reports when touch icons cannot be themed or an SVG logo cannot be converted to PNG for emails. Closes #36607 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
feat/theming-svg-favicon
branch
from
September 24, 2026 09:20
8281c20 to
d9e2b04
Compare
Contributor
Author
|
Ok, we cannit remove the requirement as touch icons are still nor accepted as svgs which is a requirement for Safari on ios and macos. So wr cannot push forward with this... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The favicon endpoint now returns an SVG that embeds the app icon on the
themed background, instead of rendering an ICO file with imagick. This
removes the imagick requirement for favicons and allows uploading SVG
favicons without imagick.
Touch icons need to be PNG for Safari "Add to Dock" and the iOS home
screen, so they are still rendered with imagick when available and fall
back to the default touch icon otherwise. An uploaded favicon is served
as-is by both endpoints.
The manifest declares the type of the served icons, and the social
media preview image of shares is only replaced by the touch icon if it
is a raster image.
The imagick setup check now only reports when touch icons cannot be
themed or an SVG logo cannot be converted to PNG for emails.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)