fix(files_sharing): show clearer message when share creation is rate limited - #64705
Open
sundeep8967 wants to merge 2 commits into
Open
sundeep8967 wants to merge 2 commits into
sundeep8967 wants to merge 2 commits into
Conversation
…limited Handle HTTP 429 response when creating shares by displaying a dedicated translated rate-limiting message instead of a generic failure notice. Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
sundeep8967
requested review from
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
September 23, 2026 20:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When share creation hits the per-user rate limit (
#[UserRateLimit(limit: 20, period: 600)]onShareAPIController::createShare), the API returns HTTP 429 (Too Many Requests). Previously, the Files sharing frontend fell back to generic error notifications, leading users to believe the file or sharing dialog was broken.This change:
ShareRequests.js(getErrorMessage) and surfaces a clear, dedicated translated notification:SharingEntryLink.vueandNewFileRequestDialog.vueto also display this dedicated message upon encountering HTTP 429 instead of generic failure alerts.ShareRequests.spec.ts.Checklist