Conversation
skjnldsv
added
bug
3. to review
skjnldsv
requested review from
Altahrim,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
September 24, 2026 01:04
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
skjnldsv
force-pushed
the
fix/files-reminders-large-folders
branch
from
September 24, 2026 01:09
a54731b to
8c86d5a
Compare
ReminderService::cacheFolder() stored one entry per child in the in-memory cache, which is capped at 512 entries. Listing a folder with 512 or more children evicted entries before the DAV plugin read them, so each evicted file fell back to its own query. Keep the folder preload in a separate per-request map and drop the entry whenever a reminder is written, so later changes in the same request win. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
fix/files-reminders-large-folders
branch
from
September 24, 2026 12:28
8c86d5a to
b3aa746
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listing a folder with 512 or more entries runs one
oc_files_remindersquery per file. #50244 preloads a folder's reminders intocreateInMemory(), which is aCappedMemoryCacheof 512 entries, so large folders evict the preload before thenc:reminder-due-datehandler reads it.The preload now lives in its own per-request map. Every write still goes to the capped cache and clears the preloaded entry, so a reminder created, updated or deleted later in the same request wins. The capped cache stays for per-file lookups to keep memory bounded in background jobs.
Measured on a local instance (SQLite, APCu, Redis), Depth 1 PROPFIND with the props the Files app requests, interleaved runs:
Responses are byte-identical to master for 22,815 entries across 18 PROPFIND and SEARCH requests, including folders with reminders. On MySQL or Postgres each saved query is also a network round trip, so the gain should be larger there.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.