Preparations for Unified Sharing Legacy Sync - #64733
Open
provokateurin wants to merge 13 commits into
Open
provokateurin wants to merge 13 commits into
provokateurin wants to merge 13 commits into
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…is done Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…te the recipients Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
September 24, 2026 15:01
provokateurin
added
bug
3. to review
provokateurin
changed the title
Member
Author
|
/backport to stable35 |
icewind1991
approved these changes
Sep 24, 2026
come-nc
requested changes
Sep 24, 2026
| } | ||
|
|
||
| if ($share->getPassword() !== null && !$share->isPasswordHashed()) { | ||
| throw new RuntimeException('The password must be hashed already.'); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException('The password must be hashed already.'); | |
| throw new \RuntimeException('The password must be hashed already.'); |
Contributor
There was a problem hiding this comment.
there is another instance of the same typo in the file
| private readonly ISharingManager $manager, | ||
| ) { | ||
| $eventDispatcher->addServiceListener(GroupDeletedEvent::class, self::class); | ||
| $eventDispatcher->addServiceListener(BeforeGroupDeletedEvent::class, self::class); |
Contributor
There was a problem hiding this comment.
Why is that a before deletion listener?
If deletion fails you still deleted the data.
Should be listener on groupdeletedevent with a high priority, no?
Contributor
There was a problem hiding this comment.
same remark for the user listener
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #64737.
A lot of random things had to be adjusted or fixed. This is not even all, but I just wanted to make a first batch to get that out of the way. The tests will probably not pass right away, because I didn't run all of them locally.