Conversation
Show a "Use another method" link on the challenge page when another regular provider is available, so users can go back to the selection page instead of cancelling the login. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Member
Author
|
Created it from the wrong origin... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Once a 2FA method is picked on the selection page, the challenge page only offers "Use backup code" and "Cancel login". If I pick Nextcloud Notification but have no logged-in device at hand, the only way to use TOTP instead is "Cancel login", which logs out and means typing the password again.
This adds a "Use another method" link to the challenge page that goes back to
/login/selectchallenge, keepingredirect_url. The pending 2FA session is untouched sinceselectChallengeis a plain GET, so nothing changes on the session side.The link only shows when there is another regular provider than the current one. With only TOTP + backup codes, the existing "Use backup code" link already covers it, so it stays hidden. On the backup codes page it shows as soon as a regular provider exists.
Checklist
3. to review, feature component)stable32)AI (if applicable)