fix(occ): dispatch password reset events for user:resetpassword - #64764
Open
joshtrichards wants to merge 2 commits into
Open
joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Emit BeforePasswordResetEvent before setting the password and PasswordResetEvent only after the password change succeeds. Emitting these events is the correct lifecycle behavior and lets server-side encryption use its reset flow instead of treating the CLI operation as a normal password change, matching the web-based lost-password flow. Because this command does not provide an encryption recovery password, existing encrypted files may become inaccessible after the reset. The interactive CLI and web flow warn about this; the --password-from-env path does not, which is existing behavior. Fixes #51235 Signed-off-by: Josh <josh.t.richards@gmail.com>
Verify that user:resetpassword dispatches reset events around a successful password change and does not dispatch PasswordResetEvent when the change fails. Assisted-by: Copilot:gpt-6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
salmart-dev and
sorbaugh
and removed request for
a team
September 25, 2026 12:47
joshtrichards
added
3. to review
susnux
approved these changes
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
occ user:resetpasswordfails when server-side encryption is enabled #51235Summary
Emit
BeforePasswordResetEventbefore setting the password andPasswordResetEventonly after the password change succeeds. Emitting these events is the correct lifecycle behavior and lets server-side encryption use its reset flow instead of treating the CLI operation as a normal password change, matching the web-based lost-password flow.Because this command does not provide an encryption recovery password, existing encrypted files may become inaccessible after the reset. The interactive CLI and web flow warn about this; the
--password-from-envpath does not, which is existing behavior.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)