fix(appstore): do not wrap app store screenshots in the proxy twice - #64771
Open
martin-rueegg wants to merge 1 commit into
Open
martin-rueegg wants to merge 1 commit into
martin-rueegg wants to merge 1 commit into
Conversation
The app store now serves screenshot URLs already pointing at usercontent.apps.nextcloud.com. Wrapping them again names a file the proxy never stores the image under, so no app shows its screenshot. Pass such URLs through unchanged, and encode the others with the URL-safe alphabet the proxy stores its files under. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
martin-rueegg
requested review from
leftybournes,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team
September 25, 2026 20:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since nextcloud/appstore@fd69d12680,
apps.jsonserves every screenshot URL already in proxy form,https://usercontent.apps.nextcloud.com/<base64url of the source>(all 1267 in/api/v1/platform/33.0.0/apps.jsonon 2026-09-25).ApiControllerwraps it in the proxy again, so the Apps page links to a key the proxy never stores the image under. Today every app's preview is empty or a "Preview not available" placeholder, including apps whose screenshots load on apps.nextcloud.com.createProxyPreviewUrl()now passes a URL already in proxy form through unchanged, and the app list uses it too instead of its own inline copy. URLs still wrapped here, from an app's owninfo.xml, are encoded with the URL-safe alphabet the proxy stores its files under since nextcloud/usercontent.apps.nextcloud.com#25; plainbase64_encodemisses whenever the encoding contains+or/.The double-wrapped keys that answer at all today do so only because of a proxy bug that caches placeholders under them, fixed in nextcloud/usercontent.apps.nextcloud.com#31.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
🤖 Generated with Claude Code