Conversation
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IQueryBuilder::ignoreConflictsOnInsert()to mark an INSERT asconflict tolerant. The SQL rewrite happens in
getSQL()via a newAdapter::getInsertIgnoreSqlTransformer()(INSERT IGNORE forMySQL/MariaDB, ON CONFLICT DO NOTHING for PostgreSQL/SQLite, plain
INSERT as fallback), so typed parameters and shard-key hints survive.
Adapter*::insertIgnoreConflict()to use the flag instead ofediting the SQL string and calling the connection directly.
QBMapper::insertIgnoreConflict(Entity $entity): int, porting thecapability of the Collectives
TInsertIgnoreConflicttrait into core,returning the number of inserted rows (0 when a conflicting row exists).
Tests
tests/lib/DB/QueryBuilder/QueryBuilderTest.php: SQL transform perplatform, end-to-end conflict insert, LogicException on non-INSERT.
tests/lib/AppFramework/Db/QBMapperTest.php/QBMapperDBTest.php:typed parameter mapping, conflict returns 0 without overwriting the row.
Checklist
3. to review, feature component)stable32)AI (if applicable)